Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes input box weirdness for numeric questions w/ large units text #1843

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Fixes input box weirdness for numeric questions w/ large units text #1843

merged 3 commits into from
Jul 19, 2021

Conversation

jpeterson976
Copy link
Contributor

Resolves #1826

@jpeterson976 jpeterson976 requested review from a team, iturgeon and sergioncp and removed request for a team, iturgeon and sergioncp June 1, 2021 18:15
zachberry
zachberry requested changes Jun 2, 2021
View reviewed changes
Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final change, would like the checkmark or X to also be centered, seen here:

image

zachberry
zachberry requested changes Jun 3, 2021
View reviewed changes
Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an issue when feedback is involved:

image

Otherwise, I tested various examples of both types of questions, both with and without feedback and with and without lots of text and all other cases look good.

@zachberry zachberry added this to the 23 - Rose Quartz milestone Jun 14, 2021
@zachberry zachberry modified the milestones: 23 - Rose Quartz, 24 - TBA Jun 24, 2021
@jpeterson976 jpeterson976 changed the base branch from dev/22-aquamarine to dev/24-sunstone June 28, 2021 18:52
@jpeterson976
Copy link
Contributor Author

I noticed that the review flags when you click "Reveal Answer" were also not aligned properly, so I fixed that as well. I added some adjustments to the more info button for smaller screen sizes too, since it was hidden by the input box at sub-tablet sizes.

zachberry
zachberry approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with numeric and MC questions, both in practice and assessment, at all mobile sizes, and tested with ChromeVox, and found no issues - looks great!

maufcost
maufcost reviewed Jul 19, 2021
View reviewed changes
Copy link
Contributor

@maufcost maufcost left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this comment (Was supposed to be a review...) (Review below)

maufcost
maufcost approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@maufcost maufcost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with the same tools and sizes as Zac above ^ Good job!

@zachberry zachberry merged commit 80db90e into ucfopen:dev/24-sunstone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maufcost maufcost maufcost approved these changes

@zachberry zachberry zachberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24 - Sunstone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpeterson976 @zachberry @maufcost