Added loading spinners to dashboard #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maufcost
requested review from
a team,
sergioncp and
jpeterson976
and removed request for
a team
zachberry
requested changes
Jul 20, 2021
jpeterson976
previously approved these changes
Jul 22, 2021
|
Also, this seems to cover #1853 as well |
zachberry
requested changes
Jul 29, 2021
packages/app/obojobo-repository/shared/components/dashboard.scss
Outdated
Show resolved
Hide resolved
zachberry
approved these changes
Jul 29, 2021
jpeterson976
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I re-used obo's spinner from
obojobo-document-enginefor consistency. Let me know if you would like me to re-design another one exclusively for the dashboard. The spinner is centered horizontally as requested and has a subtle margin from the top. As always, I am open for any changes.Fixes #1849