Added support for colored list indices and bullet points #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maufcost
requested review from
a team,
iturgeon and
sergioncp
and removed request for
a team
jpeterson976
approved these changes
Aug 11, 2021
zachberry
requested changes
Aug 16, 2021
| @@ -14282,6 +14282,11 @@ url@^0.11.0: | |||
| punycode "1.3.2" | |||
| querystring "0.2.0" | |||
|
|
|||
| use-debounce@^7.0.0: | |||
There was a problem hiding this comment.
That is weird. I didn't install it. Is it possible that somehow it installed it when I ran yarn install when I cloned the repo?!
There was a problem hiding this comment.
It's possible (and likely lol) that it might be a mistake on a previous PR I made, and neglected to commit the yarn.lock file. I'm okay merging it in then
There was a problem hiding this comment.
It's up to you. I can try downgrading it if you want me to.
zachberry
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change my approach a couple times to facilitate testing.
Besides all the precedence CSS/Sass I dealt with, I ended up creating a new function on obo's
MockElementclass to give us the supposed color of list indices and bullet points (right now, in order to be more careful and as expected, this function only works with list elements with text inside since we may have other types of elements as list elements).As always, I'd be glad to address any requested changes.
Fixes #1763