Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty XML style tags when saving #1895

Conversation

jpeterson976
Copy link
Contributor

Fixes #1654

I added a check that sets node.value = '' if it doesn't already exist, which prevents the saving error from occurring and lets the empty tag get removed when swapping to the JSON/Visual Editor and back.

@jpeterson976 jpeterson976 requested review from a team, zachberry and maufcost and removed request for a team August 12, 2021 20:37
Copy link
Contributor

@maufcost maufcost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This works pretty well as far as my tests go. Clap Clap!

I tested by:

  • Creating empty <b></b>, <i></i>, and others and going back and forth between editors.
  • Styling empty spaces (also in conjunction with other text tags e.g. text, textGroup, etc)

Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zachberry zachberry merged commit ee3b0b6 into ucfopen:dev/25-bixbite Aug 16, 2021
@zachberry zachberry added this to the 25 - Bixbite milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants