Standardized clear filter button #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrenjaminBanklin
requested changes
Nov 22, 2021
There was a problem hiding this comment.
This looks good, and it does the job.
Only thing I can think of - now that we have full control over how this looks, add a cursor: pointer; to round out the clickable button-ness of it.
It'd be nice if we could also make sure this shows up in Firefox, but it looks like that would require disabling the browser's pseudo-element and constructing our own instead. That will probably have to be its own issue.
jpeterson976
previously approved these changes
Nov 23, 2021
|
I just found a solution for Firefox specifically. I will be committing that later today. |
|
Everything seems to be working now on all three browsers. I'm just gonna be converting some measurement units from 'px' to 'em' for consistency now. |
FrenjaminBanklin
approved these changes
Nov 30, 2021
jpeterson976
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I overrode
web-kit's UI for our clear filter button within obo's dashboard's search input, and everything seems to be standardized across browsers now.Fixes #1930