Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made it so that removing your own access to a module calls onClose() #1943

Merged
merged 1 commit into from
Jan 27, 2022
Merged

made it so that removing your own access to a module calls onClose() #1943

merged 1 commit into from
Jan 27, 2022

Conversation

SJJacques
Copy link
Contributor

Tested on Firefox, Chrome, and Safari; automated tests pass and coverage is met.

@SJJacques SJJacques linked an issue Dec 10, 2021 that may be closed by this pull request
When removing your own access to a module, close the share dialog. #1931
Closed
@SJJacques SJJacques changed the base branch from master to dev/26-neon-apatite December 10, 2021 17:29
jpeterson976
jpeterson976 previously approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@jpeterson976 jpeterson976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialog properly closes. LGTM!

deundrewilliams
deundrewilliams previously approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@deundrewilliams deundrewilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in each browser and share dialog closed for each one

FrenjaminBanklin
FrenjaminBanklin previously approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low impact and does the job. Good work.

@FrenjaminBanklin FrenjaminBanklin changed the base branch from dev/26-neon-apatite to dev/27-pyrite January 5, 2022 14:53
@FrenjaminBanklin FrenjaminBanklin dismissed stale reviews from deundrewilliams, jpeterson976, and themself January 5, 2022 14:53

The base branch was changed.

jpeterson976
jpeterson976 approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@jpeterson976 jpeterson976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialog still closes with new base branch, re-approving

maufcost
maufcost approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@maufcost maufcost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM!

@FrenjaminBanklin FrenjaminBanklin merged commit 3c2c07f into ucfopen:dev/27-pyrite Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeterson976 jpeterson976 jpeterson976 approved these changes

@maufcost maufcost maufcost approved these changes

@deundrewilliams deundrewilliams deundrewilliams left review comments

@FrenjaminBanklin FrenjaminBanklin FrenjaminBanklin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When removing your own access to a module, close the share dialog.
5 participants
@SJJacques @FrenjaminBanklin @maufcost @deundrewilliams @jpeterson976