Issue/290 iframe content detected #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rob-3 The PHPAlly version this PR was waiting on exists now. The current definition for PHPAlly in composer.json is ~1.1.0, which should resolve to 1.1.1 once you update the composer.lock file. Please check out this branch, update the composer.lock file, verify that it pulled PHPAlly 1.1.1, and commit that new lock file to this branch. Then assign me as a reviewer and @ me. |
…ame-content-detected
…ame-content-detected
bagofarms
changed the title
|
This works fine on my end and I see no problems. I will go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #290
Waiting on phpally issue 23 (Add IframeNotHandled rule) to be merged into phpally so that we can update the phpally version to include this rule.