148 format validation vulnerability #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
force-pushed
the
148-format-validation-vulnerability
branch
from
d179add to
6b385b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148
Fixes regular expression validation of phone number.
Our previous regular expression validation of the phone number has a security vulnerability. A phone number like "123-456-7890 malicious_code_here" would have been marked as valid. This fix removes that vulnerability. By adding in anchors to the regex check: (/\A\d{3}-\d{3}-\d{4}\z/), we ensure that the string is exactly a phone number in the format 111-111-1111 and nothing else.
Rspec: also included a happy path and more edge case checks for phone number validation.