202: updated pagy to 6.0.4, updated config/initializers/pagy file #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
changed the title
Janell-Huyck
changed the title
|
Sorry, this needs to rebase over qa. |
Janell-Huyck
force-pushed
the
202-update-pagy-to-6-0-4
branch
from
2675c98 to
3a9abf9
Compare
|
Rebased from qa |
Janell-Huyck
force-pushed
the
202-update-pagy-to-6-0-4
branch
from
3a9abf9 to
0e20965
Compare
|
Rebased from qa (again) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202
Reference: the pagy change logs for version 5.0.0
There was a breaking change for us in moving from pagy version 3.11.0 to version 6.0.4. Upon migrating from 4.11.0 to 5.0.0, support had been removed for the deprecated variable Pagy::VARS. Instead, it had been renamed to Pagy::DEFAULT. We had used Pagy::VARS in our config/initializers/pagy.rb file, so when we were attempting to migrate to 6.0.4, we were unable to successfully initialize anything that used pagy.
This PR: