Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

217 part 1: make error pages load dynamically #226

Conversation

Janell-Huyck
Copy link
Contributor

refs #217

Make 404, 422, and 500 error pages load dynamically

In order for the error pages to be dynamically loading templates, they need to be moved out of the public directory and into views. This involves adding routes for the pages and a new controller to send things in the right direction.

@Janell-Huyck Janell-Huyck changed the title 217 make error pages load dynamically 217 part 1 - make error pages load dynamically Sep 29, 2023
@Janell-Huyck Janell-Huyck changed the title 217 part 1 - make error pages load dynamically 217 part 1: make error pages load dynamically Sep 29, 2023
@crowesn crowesn self-assigned this Oct 4, 2023
Copy link
Contributor

@crowesn crowesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging.

@crowesn crowesn merged commit 81b209d into 217-feature-branch-error-pages-css-fix Oct 4, 2023
@crowesn crowesn deleted the 217-make-error-pages-load-dynamically branch October 4, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants