Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

217 part 3: fix 404 error page content #229

Merged
merged 9 commits into from
Oct 5, 2023
Merged

Conversation

Janell-Huyck
Copy link
Contributor

refs #217

Fixes the 404 error page content.

Adds image of empty bookshelf and updates the text content. Image came from free site Pixabay.com, which allows use of their images on commercial sites.

View should be mobile-friendly and img should be accessible-compliant. I've added an alt-text to the image but am unsure about any other compliance items for UC.

@crowesn crowesn self-assigned this Oct 5, 2023
@Janell-Huyck Janell-Huyck force-pushed the 217-fix-404-error-page-content branch from e0c0e76 to c93ca92 Compare October 5, 2023 16:21
Copy link
Contributor

@crowesn crowesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew looks good. Merging!

@crowesn crowesn merged commit 48e1a82 into qa Oct 5, 2023
@crowesn crowesn deleted the 217-fix-404-error-page-content branch October 5, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants