Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

256 fixed flash messages to display for all views #257

Merged
merged 2 commits into from
Oct 19, 2023
Merged

256 fixed flash messages to display for all views #257

merged 2 commits into from
Oct 19, 2023

Conversation

Janell-Huyck
Copy link
Contributor

@Janell-Huyck Janell-Huyck commented Oct 18, 2023 •
edited
Loading

Fixes #256

  • Pulls the logic for displaying flash messages from inside individual views to outside in the application.html.layout
  • Makes flash notices and warnings able to be displayed on any page
  • Updates tests to match new requirements
  • Corrects HTML layout issues where divs weren't closed or were misaligned
  • Removes obsolete and non-working link to <script src='https://kit.fontawesome.com/a076d05399.js'></script> from application template

@scherztc scherztc self-assigned this Oct 18, 2023
@Janell-Huyck Janell-Huyck changed the title fixed flash messages to display for all views 256 fixed flash messages to display for all views Oct 19, 2023
@scherztc scherztc merged commit 9da616e into qa Oct 19, 2023
@scherztc scherztc deleted the 256-fix-flash-messages branch October 19, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scherztc scherztc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flash notices not working on all pages
2 participants
@Janell-Huyck @scherztc