296 - Refactor show/hide 'other' college field

[Janell-Huyck]

Fixes #296

Refactor of setupOtherCollegeCheckbox Function for Dynamic Form Interaction

Overview

This pull request introduces a refactor of the setupOtherCollegeCheckbox function. The refactor enhances the interaction with the "Other College" checkbox and related text field in our forms, specifically on the edit and new pages. The changes improve the code's readability and functionality, ensuring a more intuitive user experience.

Key Changes

Integration with Turbolinks:

The function is now explicitly executed only when the Turbolinks load event is triggered and on specific pages ("/edit" and "/new"). This ensures the code runs only in the relevant context, improving performance and preventing unnecessary executions.

Dynamic State Synchronization:

Implemented logic to check the "Other College" checkbox automatically if the corresponding text field has a pre-filled value. This is particularly useful in edit forms, ensuring that the state of the checkbox correctly reflects the existing data.

Visibility Control of the Text Field:

Adjusted the code to show or hide the "Other College" text field based on the state of the checkbox. This makes the form more dynamic and responsive to user input, improving the overall user experience.

Introduction of tempStorage for State Preservation:

Added a tempStorage property to the text field element to store its value temporarily. This allows for the text field's content to be preserved and restored if the checkbox is toggled, preventing data loss during user interaction.

Refined Event Handling:

Replaced inline event handling with a more robust event listener attached to the checkbox. This approach follows best practices for event handling in JavaScript and enhances maintainability.

Move repeated College fields and logic to its own partial

Each of the publication types' forms repeated the block of college selection and the "other" college field. I took this PR as an opportunity to move this block into a partial to DRY the code up a bit and to make future maintenance easier. It will also place the Other College selection field in a consistent place in each of the publication types.