Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

334 - Upgrade to Ruby 3.3.0 #336

Merged
merged 3 commits into from
Feb 1, 2024
Merged

334 - Upgrade to Ruby 3.3.0 #336

merged 3 commits into from
Feb 1, 2024

Conversation

Janell-Huyck
Copy link
Contributor

Fixes #334

This PR updates AAEC to Ruby version 3.3.0. It updates it in CI, the ruby-version file, and the Gemfile. Because I updated the Gemfile, I went and re-ran "bundle install" to make sure everything was installed properly. This incidentally updates some of the versions in Gemfile.lock, but this was not a "bundle update" update.

@Janell-Huyck Janell-Huyck added ruby Pull requests that update Ruby code needed for deploy labels Jan 17, 2024
@Janell-Huyck Janell-Huyck changed the title Upgrade to Ruby 3.3.0 334 - Upgrade to Ruby 3.3.0 Jan 18, 2024
@Janell-Huyck Janell-Huyck force-pushed the 334-upgrade-to-ruby-3.3.0 branch from b5643dd to 31cc4dd Compare January 24, 2024 22:06
Copy link
Member

@hortongn hortongn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Janell-Huyck There's also an rbenv line in config/deploy.rb that needs to be changed to 3.3.0. The README currently mentions ruby 3.2.2 - we should either update the version number or remove it from the README. Please deploy this branch to libappstest after you make the changes and verify all is well. Thanks

@hortongn hortongn self-assigned this Jan 30, 2024
@Janell-Huyck Janell-Huyck force-pushed the 334-upgrade-to-ruby-3.3.0 branch from f429ec7 to 4f7be79 Compare January 31, 2024 21:55
@Janell-Huyck Janell-Huyck force-pushed the 334-upgrade-to-ruby-3.3.0 branch from 6524b3d to c40c05f Compare February 1, 2024 20:09
@Janell-Huyck
Copy link
Contributor Author

This will deploy on libappstest with the following steps:

  1. ssh apache@libappstest.libraries.uc.edu (password in config vault)
  2. set the ruby local version to 3.3.0 with rbenv local 3.3.0, and then exit ssh
  3. cap qa deploy from the command line outside of the server

To deploy for production in libapps, we will need to install Ruby version 3.3.0 with the following steps:

  1. ssh into libapps
  2. update the dependency ruby-build with git -C /home/apache/.rbenv/plugins/ruby-build pull
  3. install Ruby 3.3.0 with RUBY_CONFIGURE_OPTS="--disable-dtrace" rbenv install 3.3.0. (Note dtrace needs to be disabled since we don't have it installed and don't want it.)
  4. set the ruby local version to 3.3.0 with rbenv local 3.3.0 and then exit ssh
  5. cap production deploy from the command line outside the server

@Janell-Huyck Janell-Huyck requested a review from hortongn February 1, 2024 20:15
@hortongn hortongn merged commit b3c22d9 into qa Feb 1, 2024
1 of 2 checks passed
@hortongn hortongn deleted the 334-upgrade-to-ruby-3.3.0 branch February 1, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needed for deploy ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Ruby 3.3.0
2 participants