-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
334 - Upgrade to Ruby 3.3.0 #336
Conversation
b5643dd
to
31cc4dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Janell-Huyck There's also an rbenv line in config/deploy.rb that needs to be changed to 3.3.0. The README currently mentions ruby 3.2.2 - we should either update the version number or remove it from the README. Please deploy this branch to libappstest after you make the changes and verify all is well. Thanks
f429ec7
to
4f7be79
Compare
I wasn't able to deploy the branch. Libappstest doesn't seem to have Ruby version 3.3.0 installed via rbenv. See Teams thread https://teams.microsoft.com/l/message/19:93d7555d783b4397aa7814cfe8e70c0d@thread.skype/1706740878406?tenantId=f5222e6c-5fc6-48eb-8f03-73db18203b63&groupId=05379e3e-d136-48a1-ba71-81ecaf83cfab&parentMessageId=1706740878406&teamName=UCL%20Application%20Development%20Unit&channelName=aaec&createdTime=1706740878406 |
6524b3d
to
c40c05f
Compare
This will deploy on libappstest with the following steps:
To deploy for production in libapps, we will need to install Ruby version 3.3.0 with the following steps:
|
Fixes #334
This PR updates AAEC to Ruby version 3.3.0. It updates it in CI, the ruby-version file, and the Gemfile. Because I updated the Gemfile, I went and re-ran "bundle install" to make sure everything was installed properly. This incidentally updates some of the versions in Gemfile.lock, but this was not a "bundle update" update.