Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run bundler update to fix bundler audit vulnerabilities #367

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

Janell-Huyck
Copy link
Contributor

@Janell-Huyck Janell-Huyck commented Feb 12, 2024

We had a new bundler audit vulnerability centered around Nokogiri. Upon inspection, we were not requiring Nokogiri directly, but it was a requirement for multiple gems we were using. Running "Bunlde update" fixed that vulnerability.

Also fixes #322

@hortongn
Copy link
Member

@Janell-Huyck Some failing mailer specs. A fluke or caused by updated gems?

@Janell-Huyck
Copy link
Contributor Author

@Janell-Huyck Some failing mailer specs. A fluke or caused by updated gems?

Caused by the gem updates. We were doing a stub_const on our ENV file, and that's now seen as changing a frozen constant. I've modified the tests so that they will be testing the same thing without stubbing, using an around block, like this:

      around do |example|
        original_mail_sender = ENV.fetch('MAIL_SENDER', nil)
        ENV['MAIL_SENDER'] = 'sender@example.com'
        example.run
        ENV['MAIL_SENDER'] = original_mail_sender
      end

@hortongn hortongn merged commit 3865230 into qa Feb 12, 2024
2 checks passed
@hortongn hortongn deleted the bundle-update-feb-12-2024 branch February 12, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Bundle Update before Next deploy
2 participants