247/adjust submitter login page #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247
This PR makes the login page in desktop and tablet views have the submitter form in a 2-column format. Mobile views have a single-column format.
It creates the two-column format by creating a few new SCSS class names: "two-column-form", "two-column-item", "add-padding-bottom" and "two-column-left-button". These are designed to be reusable for making the "new" and "edit" publication pages also into a two-column format.
Tests ensure that the submitter creation page displays a 2-column format correctly since it used to have this property and was switched unintentionally to a single-column layout sometime in the last few years. The tests are designed to be reusable to test the layouts of the publication pages as well.
It sets box-sizing to border-box for the entire app to assist with creating a more uniform layout.
It also removes the underline from the "LIBRARIES" link on the header to conform to UC styling guidelines.