fix code smell in TestAccUCloudInstanceState

ucloud · Aug 27, 2023 · b2d3594 · b2d3594
1 parent d68110b
commit b2d3594
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/ucloud/resource_ucloud_instance_state_test.go b/ucloud/resource_ucloud_instance_state_test.go
@@ -9,13 +9,13 @@ import (
 )
 
 func TestAccUCloudInstanceState(t *testing.T) {
-
+	instanceStateResource := "ucloud_instance_state.foo"
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck: func() {
 			testAccPreCheck(t)
 		},
 
-		IDRefreshName: "ucloud_instance_state.foo",
+		IDRefreshName: instanceStateResource,
 		Providers:     testAccProviders,
 		CheckDestroy:  testAccCheckInstanceStateDestroy,
 
@@ -25,15 +25,15 @@ func TestAccUCloudInstanceState(t *testing.T) {
 
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("ucloud_instance.foo", "name", "tf-acc-instance-config-basic"),
-					resource.TestCheckResourceAttr("ucloud_instance_state.foo", "state", "Stopped"),
+					resource.TestCheckResourceAttr(instanceStateResource, "state", "Stopped"),
 				),
 			},
 			{
 				Config: testAccInstanceStateConfigUpdate(),
 
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("ucloud_instance.foo", "name", "tf-acc-instance-config-basic"),
-					resource.TestCheckResourceAttr("ucloud_instance_state.foo", "state", "Running"),
+					resource.TestCheckResourceAttr(instanceStateResource, "state", "Running"),
 				),
 			},
 		},