Use local type declaration for POSIX standard type only for MS compiler #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
well, are you sure that vc++/Visual Studio defines ssize_t ? I know that it defines SSIZE_T, but I do not find ssize_t i would have done : #ifdef _MSC_VER |
ssize_t is a POSIX type which is declared in POSIX include files. Mingw-w64 provides it also for Windows. Use the local declaration only with MS compilers. Signed-off-by: Stefan Weil <sw@weilnetz.de>
|
Thank you for your hint. I only have Mingw-w64 installed locally, so could not test it with VS, but MSDN confirms what you said. I updated the commit as suggested. |
stweil
changed the title
|
Updated subject line and description of PR to match updated commit. |
|
It looks like the continuous integration test still does not check the JPIP part of the code. See pull request #692 which tried to fix that some years ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssize_t is a POSIX type which is declared in POSIX include files.
Mingw-w64 provides it also for Windows.
Use the local declaration only with MS compilers.
Signed-off-by: Stefan Weil sw@weilnetz.de