Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opj_write_bytes_BE (#518) #521

Merged
merged 1 commit into from
Jul 25, 2015
Merged

Fix opj_write_bytes_BE (#518) #521

merged 1 commit into from
Jul 25, 2015

Conversation

manisandro
Copy link
Contributor

This patch, originally by @szukw000, fixes the issue where opj_compress + opj_decompress fails on bigendian systems.

@detonin
Copy link
Contributor

detonin commented Jul 3, 2015

@manisandro Many thanks for the PR.
@sharkcz I do not have access to any big endian machine: is there a way you could run the test suite with and without the patch and report results ? To run the test suite, you have to clone openjpeg-data repository, enable testing in cmake configuration, and indicate to cmake where to find openjpeg-data folder. Then, "make & make Experimental" launches the test suite and submits results to CDash dashboard (http://my.cdash.org/index.php?project=OPENJPEG). Let me know.

@mayeut
Copy link
Collaborator

mayeut commented Jul 17, 2015

This is related to #518 (already in the title but needed to properly create a link between the 2 it seems)

This was referenced Jul 17, 2015
Closed
Closed
Closed
@szukw000
Copy link
Contributor

@detonin, I have done both.

Site name: G5
Build name: Linux-(g5-3.16.0-4-powerpc64-#1-SMP-Debian-3.16.7-ckt11-1-(2015-05-24)-ppc64-GNU/Linux)

The first is without, the second with, the cio.c patch of #518.

winfried

mayeut added a commit that referenced this pull request Jul 25, 2015
@mayeut
Merge pull request #521 from manisandro/bigendian
8c4afef 
Fix opj_write_bytes_BE
Fixes #472 
Fixes #345 
Fixes #518
@mayeut mayeut merged commit 8c4afef into uclouvain:master Jul 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manisandro @detonin @mayeut @szukw000