fix static build only against tiff and its indirect dependencies #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to get all required CFLAGS/LDFLAGS in case of static only build. This build issue [1] was triggered by the Buildroot farms. [1] http://autobuild.buildroot.net/results/d0d/d0d22727311d6300e0e400728126170407bfd699/build-end.log Signed-off-by: Samuel Martin <s.martin49@gmail.com>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Nov 13, 2016
This change adds a patch to openjpeg fixing the tiff indirect dependencies in case of static build. A similar patch for upstream master has been submitted [1]. Fixes: http://autobuild.buildroot.net/results/d0d/d0d22727311d6300e0e400728126170407bfd699/ and many others... [1] uclouvain/openjpeg#866 Signed-off-by: Samuel Martin <s.martin49@gmail.com> Cc: Olivier Schonken <olivier.schonken@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
pseiderer
added a commit
to pseiderer/openjpeg
that referenced
this pull request
Nov 14, 2016
This change allows to get all required CFLAGS/LDFLAGS in case of static only build. Fixes a buildroot build failure (see [1], [2] and [3]). [1] http://autobuild.buildroot.net/results/5ce/5cee20afd8bef5268832cddcb3a5270746be7a57 [2] http://lists.busybox.net/pipermail/buildroot/2016-November/177187.html [3] http://lists.busybox.net/pipermail/buildroot/2016-November/177188.html Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Depends on uclouvain#866
|
@rouault do you have some comments on this PR? It would be great if could be merged so we could remove it from buildroot. |
|
I'm not a CMake expert, but I'm wondering what is the effect on this change on dynamic builds |
|
This change will not break dynamic builds, it has been applied in buildroot for more than 4 years now. You can find more information about pkg-config here: https://linux.die.net/man/1/pkg-config. Basically, with this change, the |
|
ok thanks for the explanations. let's merge this |
|
Thanks, if you could also merge #867, it would be perfect. If you have any issues related to these these pull requests, do not hesitate to ping me. |
pseiderer
added a commit
to pseiderer/openjpeg
that referenced
this pull request
Jan 4, 2021
This change allows to get all required CFLAGS/LDFLAGS in case of static only build. Fixes a buildroot build failure (see [1], [2] and [3]). [1] http://autobuild.buildroot.net/results/5ce/5cee20afd8bef5268832cddcb3a5270746be7a57 [2] http://lists.busybox.net/pipermail/buildroot/2016-November/177187.html [3] http://lists.busybox.net/pipermail/buildroot/2016-November/177188.html Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Depends on uclouvain#866
msabwat
pushed a commit
to msabwat/openjpeg
that referenced
this pull request
Jun 10, 2021
This change allows to get all required CFLAGS/LDFLAGS in case of static only build. Fixes a buildroot build failure (see [1], [2] and [3]). [1] http://autobuild.buildroot.net/results/5ce/5cee20afd8bef5268832cddcb3a5270746be7a57 [2] http://lists.busybox.net/pipermail/buildroot/2016-November/177187.html [3] http://lists.busybox.net/pipermail/buildroot/2016-November/177188.html Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Depends on uclouvain#866
DanielHeath
pushed a commit
to radiopaedia/openjpeg
that referenced
this pull request
Sep 21, 2021
This change allows to get all required CFLAGS/LDFLAGS in case of static only build. Fixes a buildroot build failure (see [1], [2] and [3]). [1] http://autobuild.buildroot.net/results/5ce/5cee20afd8bef5268832cddcb3a5270746be7a57 [2] http://lists.busybox.net/pipermail/buildroot/2016-November/177187.html [3] http://lists.busybox.net/pipermail/buildroot/2016-November/177188.html Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Depends on uclouvain#866
rouault
added a commit
to rouault/openjpeg
that referenced
this pull request
Jun 27, 2022
…atic libraries are not in system directories (fixes uclouvain#1430) Note that the fix might be partial only for static-only builds (cf comments) Ammends PR uclouvain#866 and uclouvain#867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.