Skip to content

Commit

Permalink
Merge branch 'develop-2.0.0' into Feature-Issue-536-2.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
ajnelson-nist committed Aug 15, 2023
2 parents 076c66a + 824ee20 commit fb5e8d9
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 131 deletions.
9 changes: 1 addition & 8 deletions ontology/uco/observable/observable.ttl
Original file line number Diff line number Diff line change
Expand Up @@ -8886,12 +8886,6 @@ observable:WindowsThreadFacet
rdfs:label "WindowsThreadFacet"@en ;
rdfs:comment "A Windows thread facet is a grouping os characteristics unique to a single thread of execution within a Windows process."@en ;
sh:property
[
sh:datatype xsd:dateTime ;
sh:maxCount "1"^^xsd:integer ;
sh:nodeKind sh:Literal ;
sh:path observable:creationTime ;
] ,
[
sh:datatype xsd:dateTime ;
sh:maxCount "1"^^xsd:integer ;
Expand Down Expand Up @@ -10237,9 +10231,8 @@ observable:creationTime-deprecation-shape
sh:property [
a sh:PropertyShape ;
sh:maxCount "0"^^xsd:integer ;
sh:message "observable:creationTime is deprecated, and will be an error to use in UCO 2.0.0. observable:observableCreatedTime should be used instead."@en ;
sh:message "observable:creationTime is deprecated, and an error to use as of UCO 2.0.0. observable:observableCreatedTime should be used instead."@en ;
sh:path observable:creationTime ;
sh:severity sh:Warning ;
] ;
sh:targetSubjectsOf observable:creationTime ;
.
Expand Down
4 changes: 2 additions & 2 deletions ontology/uco/types/types.ttl
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ types:Thread
;
rdfs:subClassOf
co:Bag ,
core:UcoThing
core:UcoInherentCharacterizationThing
;
rdfs:label "Thread"@en ;
rdfs:comment "A semi-ordered array of items, that can be present in multiple copies. Implemetation of a UCO Thread is similar to a Collections Ontology List, except a Thread may fork and merge - that is, one of its members may have two or more direct successors, and two or more direct predecessors."@en ;
Expand All @@ -202,7 +202,7 @@ types:ThreadItem
;
rdfs:subClassOf
co:Item ,
core:UcoThing
core:UcoInherentCharacterizationThing
;
rdfs:label "ThreadItem"@en ;
rdfs:comment "A ThreadItem is a member of a thread."@en ;
Expand Down
4 changes: 2 additions & 2 deletions tests/examples/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ all: \
location_XFAIL_validation.ttl \
message_thread_PASS_validation.ttl \
message_thread_XFAIL_validation.ttl \
observable_creation_time_PASS_validation.ttl \
observable_creation_time_XFAIL_validation.ttl \
owl_axiom_PASS_validation.ttl \
owl_axiom_XFAIL_validation.ttl \
owl_properties_PASS_validation.ttl \
Expand Down Expand Up @@ -106,7 +106,7 @@ check: \
location_XFAIL_validation.ttl \
message_thread_PASS_validation.ttl \
message_thread_XFAIL_validation.ttl \
observable_creation_time_PASS_validation.ttl \
observable_creation_time_XFAIL_validation.ttl \
owl_axiom_PASS_validation.ttl \
owl_axiom_XFAIL_validation.ttl \
owl_properties_PASS_validation.ttl \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,19 @@

[]
a sh:ValidationReport ;
sh:conforms "true"^^xsd:boolean ;
sh:conforms "false"^^xsd:boolean ;
sh:result [
a sh:ValidationResult ;
sh:focusNode <http://example.org/kb/windows-thread-facet-4967ae35-f00b-49c8-9dd2-38e3bdf851e1> ;
sh:resultMessage "observable:creationTime is deprecated, and will be an error to use in UCO 2.0.0. observable:observableCreatedTime should be used instead."@en ;
sh:resultMessage "observable:creationTime is deprecated, and an error to use as of UCO 2.0.0. observable:observableCreatedTime should be used instead."@en ;
sh:resultPath observable:creationTime ;
sh:resultSeverity sh:Warning ;
sh:resultSeverity sh:Violation ;
sh:sourceConstraintComponent sh:MaxCountConstraintComponent ;
sh:sourceShape [
a sh:PropertyShape ;
sh:maxCount "0"^^xsd:integer ;
sh:message "observable:creationTime is deprecated, and will be an error to use in UCO 2.0.0. observable:observableCreatedTime should be used instead."@en ;
sh:message "observable:creationTime is deprecated, and an error to use as of UCO 2.0.0. observable:observableCreatedTime should be used instead."@en ;
sh:path observable:creationTime ;
sh:severity sh:Warning ;
] ;
] ;
.
Expand Down
12 changes: 3 additions & 9 deletions tests/examples/test_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -371,16 +371,10 @@ def test_message_thread_PASS_validation() -> None:
def test_message_thread_XFAIL_validation() -> None:
confirm_validation_results("message_thread_XFAIL_validation.ttl", False)

def test_observable_creation_time_PASS() -> None:
def test_observable_creation_time_XFAIL() -> None:
confirm_validation_results(
"observable_creation_time_PASS_validation.ttl",
True,
expected_focus_node_severities={
(
"http://example.org/kb/windows-thread-facet-4967ae35-f00b-49c8-9dd2-38e3bdf851e1",
str(NS_SH.Warning)
)
}
"observable_creation_time_XFAIL_validation.ttl",
False,
)

def test_owl_axiom_PASS() -> None:
Expand Down

This file was deleted.

This file was deleted.

10 changes: 0 additions & 10 deletions tests/shapes/test_qc_shapes.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,6 @@
@pytest.mark.parametrize(
["filename", "expected_validation_result", "expected_focus_values"],
[
(
"examples_uco_qc/co_Collection_core_UcoObject_XFAIL_validation.ttl",
False,
{
(
URIRef("http://example.org/ontology/IPAddressRoute"),
URIRef("http://example.org/ontology/IPAddressRoute"),
)
}
),
(
"examples_uco_owl/owl_incompatibleWith_shape_PASS_validation.ttl",
True,
Expand Down

0 comments on commit fb5e8d9

Please sign in to comment.