Remove unordered observable:message property

Users interested in representing a message occurring in a thread, without knowing the order of that message, should use the `co:element` property as demonstrated in the updated example `message_thread_PASS.json`. A follow-on patch will regenerate Make-managed files. References: #393 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ucoProject · Jul 21, 2022 · dcb12d5 · dcb12d5
1 parent ec00a43
commit dcb12d5
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 54 deletions.
diff --git a/ontology/uco/observable/observable.ttl b/ontology/uco/observable/observable.ttl
@@ -3908,12 +3908,6 @@ observable:MessageThreadFacet
 				co:element
 			) ;
 		] ,
-		[
-			sh:class observable:ObservableObject ;
-			sh:minCount "1"^^xsd:integer ;
-			sh:nodeKind sh:BlankNodeOrIRI ;
-			sh:path observable:message ;
-		] ,
 		[
 			sh:class observable:ObservableObject ;
 			sh:nodeKind sh:BlankNodeOrIRI ;
@@ -10660,12 +10654,6 @@ observable:maxRunTime
 	rdfs:range xsd:integer ;
 	.
 
-observable:message
-	a owl:ObjectProperty ;
-	rdfs:label "message"@en ;
-	rdfs:range observable:ObservableObject ;
-	.
-
 observable:messageID
 	a owl:DatatypeProperty ;
 	rdfs:label "messageID"@en ;

diff --git a/tests/examples/message_thread_PASS.json b/tests/examples/message_thread_PASS.json
@@ -41,26 +41,6 @@
             "@type": "observable:MessageThread",
             "core:hasFacet": {
                 "@type": "observable:MessageThreadFacet",
-                "observable:message": [
-                    {
-                        "@id": "kb:message-1"
-                    },
-                    {
-                        "@id": "kb:message-2"
-                    },
-                    {
-                        "@id": "kb:message-3"
-                    },
-                    {
-                        "@id": "kb:message-4"
-                    },
-                    {
-                        "@id": "kb:message-5"
-                    },
-                    {
-                        "@id": "kb:message-6"
-                    }
-                ],
                 "observable:messageThread": {
                     "@id": "kb:thread-1"
                 }
@@ -69,6 +49,26 @@
         {
             "@id": "kb:thread-1",
             "@type": "types:Thread",
+            "co:element": [
+                {
+                    "@id": "kb:message-1"
+                },
+                {
+                    "@id": "kb:message-2"
+                },
+                {
+                    "@id": "kb:message-3"
+                },
+                {
+                    "@id": "kb:message-4"
+                },
+                {
+                    "@id": "kb:message-5"
+                },
+                {
+                    "@id": "kb:message-6"
+                }
+            ],
             "co:size": {
                 "@type": "xsd:nonNegativeInteger",
                 "@value": "6"

diff --git a/tests/examples/message_thread_XFAIL.json b/tests/examples/message_thread_XFAIL.json
@@ -43,26 +43,6 @@
             "@type": "observable:MessageThread",
             "core:hasFacet": {
                 "@type": "observable:MessageThreadFacet",
-                "observable:message": [
-                    {
-                        "@id": "kb:message-1"
-                    },
-                    {
-                        "@id": "kb:message-2"
-                    },
-                    {
-                        "@id": "kb:message-3"
-                    },
-                    {
-                        "@id": "kb:message-4"
-                    },
-                    {
-                        "@id": "kb:message-5"
-                    },
-                    {
-                        "@id": "kb:message-6"
-                    }
-                ],
                 "observable:messageThread": {
                     "@id": "kb:thread-2"
                 }
@@ -96,7 +76,6 @@
                 }
             ],
             "co:item": [
-
                 {
                     "@id": "kb:message-thread-2-item-1"
                 },
@@ -115,7 +94,6 @@
                 {
                     "@id": "kb:message-thread-2-item-6"
                 }
-
             ],
             "types:threadOriginItem": [
                 {