Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observable:AlternateDataStream is not a subclass of FileSystemObject, but File and ReparsePoint are #590

Closed
14 tasks done
ajnelson-nist opened this issue Feb 7, 2024 · 5 comments · Fixed by #604 or #605
Closed
14 tasks done

Comments

@ajnelson-nist
Copy link
Contributor

ajnelson-nist commented Feb 7, 2024

Bug description

These lines in UCO 1.3.0 designate AlternateDataStream as a "top-level" class under ObservableObject. However, the rdfs:comment definition scopes the concept to being specific to NTFS files (and hence NTFS file systems).

It seems AlternateDataStream should be moved under observable:FileSystemObject.

Steps to reproduce

See disparity between AlternateDataStream and, e.g., ReparsePoint, another NTFS-specific file system object.

Coordination

  • Administrative review completed, proposal announced to Ontology Committees (OCs) on 2024-02-08
  • Requirements development phase skipped - proposal fast-tracked.
  • Solution form to be discussed in OC meeting, 2024-02-15
  • Solution announced to OCs on 2024-05-10
  • Solutions Approval to be discussed in OC meeting, 2024-05-30
  • Solutions Approval vote occurred, passing, on 2024-05-30
  • Solutions development phase completed.
  • Backwards-compatible implementation merged into develop for the next release
  • develop state with backwards-compatible implementation merged into develop-2.0.0
  • Backwards-incompatible implementation merged into develop-2.0.0
  • Milestone linked
  • Documentation logged in pending release page
  • Prerelease publication: CASE develop branch updated to track UCO's updated develop branch
  • Prerelease publication: CASE develop-2.0.0 branch updated to track UCO's updated develop-2.0.0 branch
@ajnelson-nist ajnelson-nist added this to the UCO 1.x.0 milestone Feb 7, 2024
@ajnelson-nist
Copy link
Contributor Author

I think the right thing to do here is:

  • In UCO 2.0.0, change the superclass.
  • In UCO 1.4.0, issue a SHACL warning if an AlternateDataStream object is not multi-typed as a FileSystemObject (i.e., a "soft" notice that the class hierarchy is changing in UCO 2.0.0).

@sbarnum
Copy link
Contributor

sbarnum commented Feb 15, 2024

I concur with this proposal and the suggested approach for 2.0.0 and 1.4.0 in the above comment.

@ajnelson-nist ajnelson-nist modified the milestones: UCO 1.x.0, UCO 1.4.0 Feb 15, 2024
ajnelson-nist added a commit that referenced this issue May 10, 2024
A follow-on patch will regenerate Make-managed files.

References:
* #590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit that referenced this issue May 10, 2024
References:
* #590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit that referenced this issue May 10, 2024
A follow-on patch will regenerate Make-managed files.

References:
* #590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit that referenced this issue May 10, 2024
References:
* #590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

I intend to handle this as a fast-track proposal. The ultimate change for UCO 2.0.0 is a 1-liner in the ontology, but we haven't held any votes yet on the "pre-2.0.0 soft warning" style of subclass hierarchy rearrangement that I've put into PR #604 .

@ajnelson-nist
Copy link
Contributor Author

Noting for the sake of review: I tested (for another proposal) whether the documentation build system would render the anonymous shape on the generated class page, when linked by rdfs:seeAlso. It does.

ajnelson-nist added a commit to casework/CASE-Archive that referenced this issue May 10, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Archive that referenced this issue May 10, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue May 10, 2024
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue May 10, 2024
References:
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Corpora that referenced this issue May 10, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue May 10, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue May 10, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

Noting for today's vote:

Unit tests have been updated, and CI passes, on both attached Pull Requests.

The PRs have not yet run through the review checklist that has often been done before holding a Solutions Approval vote.

The review checklists are in place to catch when there would be effects on any of the examples posted across CASE's example repositories. At the moment, per this data-driven list of ontology concepts used in CASE's examples, there are no instances of uco-observable:AlternateDataStream. So, the review checklist is unlikely to raise any issues.

ajnelson-nist added a commit to ucoProject/UCO-Profile-gufo that referenced this issue Jun 5, 2024
…ong exemplars

No effects were observed on Make-managed files.

References:
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE that referenced this issue Jun 10, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#586
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Corpora that referenced this issue Jun 14, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#586
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue Jun 14, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#586
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Archive that referenced this issue Jun 17, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#586
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE that referenced this issue Jun 18, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#562
* ucoProject/UCO#586
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to ucoProject/ucoproject.github.io that referenced this issue Jun 18, 2024
References:
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Jun 18, 2024
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#586
* ucoProject/UCO#590
* casework/CASE#153

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Jun 18, 2024
References:
* ucoProject/UCO#586
* ucoProject/UCO#590
* casework/CASE#153

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Jun 18, 2024
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#562
* ucoProject/UCO#586
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Jun 18, 2024
References:
* ucoProject/UCO#562
* ucoProject/UCO#586
* ucoProject/UCO#590

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment