Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and test ordering in observable:MessageThread #394

Merged
merged 10 commits into from
Jul 22, 2022
Merged

Implement and test ordering in observable:MessageThread #394

merged 10 commits into from
Jul 22, 2022

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented May 26, 2022 •
edited
Loading

This Pull Request resolves all requirements of Issue 393.

Review steps taken:

  • Pull request is against correct branch
  • CI passes in (CASE/UCO) feature branch
  • CI passes in (CASE/UCO) current unstable branch (merge-commit)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Demonstrate usage in CASE-Examples JSON files
  • Solution vote today incorporates that observable:message should be removed from observable:MessageFacet, and also removed from the ontology.

@ajnelson-nist
Implement and test ordering in observable:MessageThread
2aa0abd 
A follow-on patch will generate Make-managed files.

References:
* #393

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Generate Make-managed files
1648a99 
References:
* #393

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist linked an issue May 26, 2022 that may be closed by this pull request
Implement ordering in observable:MessageThread #393
Closed
11 tasks
@ajnelson-nist
Merge branch 'Feature-Issue-389' into Feature-Issue-393
d895e5b
@ajnelson-nist
Change reference style of Thread of Messages to behave like exifData
9dce663 
No effects were observed on Make-managed files.

References:
#393

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Add sh:nodeKind to thread properties
2c7837a 
No effects were observed on Make-managed files.

References:
#393

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Exercise shapes constraining Thread-of-Messages items
eb01aa7 
A follow-on patch will generate Make-managed files.

References:
#393

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Generate Make-managed file
bf6f9f3 
References:
#393

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Merge branch 'develop' into Feature-Issue-393
ec00a43
@ajnelson-nist
Remove unordered observable:message property
dcb12d5 
Users interested in representing a message occurring in a thread,
without knowing the order of that message, should use the `co:element`
property as demonstrated in the updated example
`message_thread_PASS.json`.

A follow-on patch will regenerate Make-managed files.

References:
#393

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
cfcbdd9 
References:
#393

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@b0bkaT b0bkaT merged commit eba573d into develop Jul 22, 2022
@ajnelson-nist ajnelson-nist mentioned this pull request Jul 22, 2022
Closed
11 tasks
@ajnelson-nist ajnelson-nist deleted the Feature-Issue-393 branch July 22, 2022 23:50
@ajnelson-nist ajnelson-nist added this to the UCO 1.0.0 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b0bkaT b0bkaT b0bkaT approved these changes

Assignees

@b0bkaT b0bkaT

Labels
None yet
Projects
None yet
Milestone
UCO 1.0.0
Development

Successfully merging this pull request may close these issues.

Implement ordering in observable:MessageThread
2 participants
@ajnelson-nist @b0bkaT