Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 596: Restructure Software class hierarchy for UCO 1.4.0 #597

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Issue 596: Restructure Software class hierarchy for UCO 1.4.0 #597

wants to merge 8 commits into from

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Mar 6, 2024 •
edited
Loading

This Pull Request resolves all backwards-compatible requirements of Issue #596 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (86e1cbd)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (4ca9dfd)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora
  • Impact on SHACL validation reviewed for CASE-Examples (Note: Incorrect Issue referenced in commit message; should be 596)
  • Impact on SHACL validation remediated for CASE-Examples
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist
Restructure Software class hierarchy for UCO 1.4.0
1dcbe20 
References:
* #596

Co-authored-by: Sean Barnum <sbarnum@mitre.org>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the UCO 1.4.0 milestone Mar 6, 2024
@ajnelson-nist ajnelson-nist linked an issue Mar 6, 2024 that may be closed by this pull request
Restructuring the Software class hierarchy #596
Open
16 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request Mar 6, 2024
Open
16 tasks
@ajnelson-nist
Fix typo
afa9c83 
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Separate realignment shapes into anonymous node shapes
dc24cb7 
This patch also updates a test result from one of the to-be-rearranged
classes.

A follow-on patch will regenerate Make-managed files.

References:
* RDFLib/pySHACL#222
* #596
* https://www.w3.org/TR/shacl/#NodeConstraintComponent

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
05b6e2f 
References:
* #596

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist and others added 4 commits May 8, 2024 16:54
@ajnelson-nist
Attach anonymous temporary warning node shapes to their corresponding…
f8c035b 
… class

This applies a practice being tried in Issue 602.

A follow-on patch will regenerate Make-managed files.

References:
* #596
* #602

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
bc4b68d 
References:
* #596

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Merge branch 'develop' into Feature-Issue-596
121f3b3
@ajnelson-nist
Update Software definitions
faae89b 
No effects were observed on Make-managed files.

AJN: This is my transcription of Sean's Issue Comment (see references),
with a few minor grammatical and typographical fixes.

References:
* #596 (comment)

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 1.4.0
Development

Successfully merging this pull request may close these issues.

Restructuring the Software class hierarchy
2 participants
@ajnelson-nist @plbt5