Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 602: Add review mechanisms for key-uniqueness in types:Dictionary #607

Merged
merged 9 commits into from
Jul 26, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Jun 4, 2024

This Pull Request will resolve all requirements of Issue #602 , as updated 2024-06-04.

This PR is built atop PR 603's current state. If no updates are made to 603, merging this PR will close 603 as well.

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (c8c5871)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (9f0ff05)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

A follow-on patch will regenerate Make-managed files.

References:
* #602

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References:
* #602

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
No effects were observed on Make-managed files.

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This manual revision is done to reduce IRI repetitions.

No effects were observed on Make-managed files.

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
… property

A follow-on patch will regenerate Make-managed files.

References:
* #602

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References:
* #602

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This has analagous rationale to UCO Issue 599, as well as supporting the
data-sharing use case where a dictionary key repetition is wished to be
shared without sharing other members of the dictionary.

No effects were observed on Make-managed files.

References:
* #599
* #602

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the UCO 1.4.0 milestone Jun 4, 2024
@ajnelson-nist ajnelson-nist linked an issue Jun 4, 2024 that may be closed by this pull request
17 tasks
ajnelson-nist added a commit to casework/CASE-Archive that referenced this pull request Jun 5, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#602
* ucoProject/UCO#607

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Archive that referenced this pull request Jun 5, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#602
* ucoProject/UCO#607

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this pull request Jun 5, 2024
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#602
* ucoProject/UCO#607

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this pull request Jun 5, 2024
References:
* ucoProject/UCO#602
* ucoProject/UCO#607

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this pull request Jun 5, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#602
* ucoProject/UCO#607

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Corpora that referenced this pull request Jun 5, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#602
* ucoProject/UCO#607

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review July 26, 2024 12:53
@ajnelson-nist ajnelson-nist requested a review from a team July 26, 2024 12:53
@plbt5 plbt5 merged commit 9a355e4 into develop Jul 26, 2024
1 check passed
@plbt5 plbt5 deleted the Feature-Issue-602-NewDictionaries branch July 26, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UCO's Dictionary class should enforce key uniqueness
2 participants