Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Frontend Packages #4

Closed
wants to merge 24 commits into from
Closed

Audit Frontend Packages #4

wants to merge 24 commits into from

Conversation

TheNewJavaman
Copy link
Contributor

@TheNewJavaman TheNewJavaman commented May 18, 2024 •
edited
Loading

Changes:

  • node to LTS (20)
  • storybook to 8.1.1 (migrated with npx storybook migrate)
  • axios to 0.28.1
  • react-refresh to 0.11.0 (override to fix react-scripts conflict)
  • stryker to 8.2.6

Notes:

  • @storybook/preset-create-react-app 8.1.1 introduces a scary-looking warning on npm start, but it's not actually an issue. This is a minor bug with react that does not affect production: facebook/create-react-app/pull/11752
  • The remaining vulnerabilities don't affect production, and "fixing" them would require pulling in older, legitimately vulnerable dependencies

Notes

When testing this PR, be sure to use:

cd frontend
nvm install lts/iron
nvm use lts/iron
npm ci

lts/iron is the latest patch version of Node 20 LTS

TheNewJavaman and others added 14 commits May 9, 2024 00:57
@TheNewJavaman
Initial spring boot 3 build compatibility
60bbb1d
@TheNewJavaman
Fix MVC, GrantedAuthoritiesService tests
5e4a77f
@TheNewJavaman
Fix abstract mock behavior in CurrentUserServiceTests
a8b8357
@pconrad
pc - do not include 'test' on the command to run 'pitest:mutationCove…
9cdfdad 
…rge'
@pconrad
pc - do not include 'test' on the command to run 'pitest:mutationCove…
4a99248 
…rge' in workflow 13
@pconrad
pc - exclude integration tests from pitest run
b9c054a
@TheNewJavaman
Merge pull request #2 from ucsb-cs156-f24/pc-spring-boot-3
5b55f96 
Fix failing tests in spring-boot-3 branch
@TheNewJavaman
Migrate Node to 20 (LTS), Storybook to 8.1.1 (latest)
a7cbedd
@TheNewJavaman
Upgrade axios to 0.28.1, fix react-refresh conflict
20c6bf0
@TheNewJavaman
Update references to Node from 16 to 20
689670c
@TheNewJavaman
Fix storybook static dir
fbe9a2f
@TheNewJavaman
Oops forgot to update workflow :O
8ba6570
@TheNewJavaman
Remove 'static' as a static directory. I enjoy programming
5b8a92c
@TheNewJavaman
so i kinda forgot about the workflows again
e78ae6e
@pconrad pconrad marked this pull request as ready for review May 19, 2024 19:52
@pconrad pconrad force-pushed the frontend-package-audit branch from e78ae6e to 6f8d9c3 Compare May 21, 2024 21:28
@TheNewJavaman TheNewJavaman requested review from pconrad and andrewpengucsb and removed request for pconrad May 22, 2024 04:31
@TheNewJavaman TheNewJavaman requested a review from pconrad May 22, 2024 04:31
andrewpengucsb
andrewpengucsb approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@andrewpengucsb andrewpengucsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad marked this pull request as draft October 11, 2024 00:34
@pconrad
Copy link
Contributor

pconrad commented Oct 11, 2024

Replaced by #15

1 similar comment
@pconrad
Copy link
Contributor

pconrad commented Oct 11, 2024

Replaced by #15

@pconrad pconrad closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpengucsb andrewpengucsb andrewpengucsb approved these changes

@pconrad pconrad Awaiting requested review from pconrad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheNewJavaman @pconrad @andrewpengucsb