Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lm show h2console link #30

Merged
merged 3 commits into from
May 29, 2024
Merged

Lm show h2console link #30

merged 3 commits into from
May 29, 2024

Conversation

miguel-luis9
Copy link
Contributor

FEATURE: H2 Console option on navbar #29

Depending on SHOW_H2_CONSOLE_ENABLED, it will show H2 Console

Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/main/resources/application-production.properties Outdated Show resolved Hide resolved
@pconrad pconrad added FIXME-See CR Please review the comments in the code review and address them; then remove this label FIXME-Stalled labels May 24, 2024
@whuang602 whuang602 added the 5 label May 28, 2024
ericknee
ericknee previously approved these changes May 29, 2024
Copy link
Contributor

@ericknee ericknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - no more comments in code

@miguel-luis9 miguel-luis9 dismissed ericknee’s stale review May 29, 2024 20:41

The merge-base changed after approval.

pconrad
pconrad previously approved these changes May 29, 2024
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguel-luis9 miguel-luis9 dismissed pconrad’s stale review May 29, 2024 20:58

The merge-base changed after approval.

@pconrad pconrad merged commit 5cf4fb5 into main May 29, 2024
9 checks passed
@pconrad pconrad removed FIXME-See CR Please review the comments in the code review and address them; then remove this label FIXME-Stalled labels May 29, 2024
@miguel-luis9 miguel-luis9 self-assigned this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants