Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create React Component for Grade Distribution History #42

Merged
merged 2 commits into from
May 29, 2024

Conversation

phamaiden
Copy link
Contributor

@phamaiden phamaiden commented May 28, 2024

In this PR, I added a basic react table component that displays the grades and count given by /api/gradehistory/search.

Closes #7

https://ucsb-cs156-s24.github.io/proj-courses-s24-4pm-1/prs/42/storybook/?path=/docs/components-gradehistory-gradehistorytable--empty

image

Copy link
Contributor

@Frank404NotFound Frank404NotFound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to run
npm run check-format
and then uses its prompt to automatically improve formatting

@pconrad pconrad added FIXME-Failing tests Please fix the failing tests (i.e. get the green check) then remove this label FixMe - Needs Peer CR labels May 28, 2024
@phamaiden phamaiden removed the FIXME-Failing tests Please fix the failing tests (i.e. get the green check) then remove this label label May 29, 2024
Copy link
Contributor

@ericknee ericknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad added the 10 label May 29, 2024
@pconrad pconrad merged commit 087d0ed into main May 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Course Grade Distribution Data - Create React Component
4 participants