Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en - changed course number input field to accept department names bef… #44

Merged
merged 2 commits into from
May 29, 2024

Conversation

ericknee
Copy link
Contributor

Fixes Issue #12
When searching for courses on the course history page, users can enter department names with their class number. Searching for "CS156" and "156" will display the same results. Before the change, searching for "CS156" or any department name would yield no results.

Before:
Screenshot 2024-05-28 at 3 17 21 PM

After:
Screenshot 2024-05-28 at 3 36 30 PM

Dokku Deployment: https://project-ericknee-dev.dokku-01.cs.ucsb.edu/courseovertime/search

Copy link
Contributor

@phamaiden phamaiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RuizheJiang
Copy link
Contributor

LGTM

Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There really should be a test for this, but maybe we'll introduce that when we have integration testing in the app.

@pconrad pconrad merged commit 234b85f into main May 29, 2024
10 checks passed
@pconrad pconrad added the 5 label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants