Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grade History Table to Course Details Page #48

Merged
merged 1 commit into from
May 29, 2024

Conversation

phamaiden
Copy link
Contributor

In this PR, I added the grade history table component to the details page of each course.

closes #16

image

Copy link
Contributor

@Frank404NotFound Frank404NotFound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like the amount of code might be worth more if being separated

@pconrad pconrad dismissed Frank404NotFound’s stale review May 29, 2024 21:04

The merge-base changed after approval.

@pconrad pconrad force-pushed the Aiden-GradeHistory-AddReactComponent branch from deafac4 to 0dd6949 Compare May 29, 2024 21:16
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad added the 10 label May 29, 2024
@pconrad pconrad added the Merge Candidate Staff code review done; waiting on CI/CD checks label May 29, 2024
@pconrad pconrad merged commit 6cb87af into main May 29, 2024
10 checks passed
@pconrad pconrad removed the Merge Candidate Staff code review done; waiting on CI/CD checks label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Course Grade Distribution Data - Add this component to the course detail page
3 participants