Make PersonalSchedule Form Description Optional #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamaiden
requested review from
pconrad,
Aasish-Virjala,
andrewpengucsb,
AnikaArora,
sangitakunapuli,
sanilkatula and
whuang602
as code owners
phamaiden
requested review from
miguel-luis9,
ericknee,
Frank404NotFound and
monicatrinh1
phamaiden
changed the title
pconrad
requested changes
May 30, 2024
frontend/src/main/pages/CourseDetails/CourseDetailsIndexPage.js
Outdated
Show resolved
Hide resolved
frontend/src/main/pages/CourseDetails/CourseDetailsIndexPage.js
Outdated
Show resolved
Hide resolved
pconrad
added
the
FIXME-See CR
ericknee
removed
the
FIXME-See CR
pconrad
reviewed
Jun 2, 2024
frontend/src/tests/pages/PersonalSchedules/PersonalSchedulesCreatePage.test.js
Outdated
Show resolved
Hide resolved
pconrad
reviewed
Jun 2, 2024
frontend/src/tests/pages/PersonalSchedules/PersonalSchedulesCreatePage.test.js
Outdated
Show resolved
Hide resolved
pconrad
reviewed
Jun 2, 2024
frontend/src/tests/pages/PersonalSchedules/PersonalSchedulesCreatePage.test.js
Outdated
Show resolved
Hide resolved
pconrad
reviewed
Jun 2, 2024
frontend/src/tests/pages/PersonalSchedules/PersonalSchedulesCreatePage.test.js
Outdated
Show resolved
Hide resolved
pconrad
added
the
FIXME-See CR
|
Deployed at https://courses-qa.dokku-01.cs.ucsb.edu/ |
phamaiden
removed
the
FIXME-See CR
pconrad
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I made the personal schedule form more user friendly by making the description field optional. Also added full test coverage.
Closes #51
In the gif below, I demonstrate the new personal schedule form. As you can see the add form no longer requires a description and the personal schedule index page correctly displays the new schedule with no description. Similarly, the edit form doesn't require a description
