-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schools Create and Index Page and Fixed Backend Issues #27
Conversation
…, having an issue with params not sending to backend
…ON format for the school
… put test and added termRegex invalidity check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I added this as a bug which I pointed out in my edit page PR, I added it as a new task on the kanban board and am fixing it in a separate PR, I believe that the index and create pages are correct |
The create school button leads to an error message for me on the dokku deployment linked in the PR. I can't merge this unless/until I can test it. |
redeployed on dokku seems to be working on my end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot delete .env.SAMPLE. It is an essential file for the app.
Also: is it the intention in this PR to have the index page and create feature for school but to have edit and delete both return errors?
That's typically not mergeable. We ask that the button at least link to a placeholder page, or put up a message sayig "not yet implemented".
I might relent in this case, but it's bad practice. So I need clarity on that.
I accidentally deleted the .env.SAMPLE file, I restored it from the version that is on the main branch The dokku deployment now has the branch version that has the real functionality for edit and delete instead of errors. I should have inserted placeholder pages however I originally intended to have implemented all 3 functionalities in the same PR but later decided to break up the PR's for organizations sake so I just never got around to putting in placeholders as I just did them one after another. |
src/main/java/edu/ucsb/cs156/organic/controllers/SchoolController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better! There is still one issue that we should address: a misunderstanding about the use case / purpose for these fielods.
…othing to do with term regex
Fixed it, now TermDescription has nothing to do with the TermRegex and the corresponding tests and checks have been modified/removed, will update the later PRs with this as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #30
Closes #29
Implemented the path for Admin to go to school management page. The NavBar takes the admin to the schools index page
Create School button leads to the create page for schools which works and successfully adds the school to the index page and the db
Back to index page
All course staff and group members should have admin access
dev deployment at this link: https://proj-organic-sr33g33-dev.dokku-12.cs.ucsb.edu/
In the backend, I changed the schoolController to take in a school json object instead of @getparams because of an issue I was facing in testing where the received input was undefined