Schools Edit Page and tests, + Minor CreatePageTest error fixed #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re how it passed github tests, changed WSMF to wsmf and testing against s24
… of api/schools so was getting blank page back
SR33G33
requested review from
pconrad,
Aasish-Virjala,
andrewpengucsb,
AnikaArora,
sangitakunapuli,
sanilkatula and
whuang602
as code owners
… and retesting, all tests pass locally
SR33G33
changed the title
|
These are kind of backend issues, Ill make a new PR to fix these after this one is merged TODO: Make the update check that the termDescription matches new TermRegex |
SR33G33
force-pushed
the
Sreeganesh-SchoolsCRUD-Edit
branch
from
9e371cd to
4bf9017
Compare
pconrad
added
the
FIXME-Merge Conflicts
SR33G33
removed
the
FIXME-Merge Conflicts
|
The create school button leads to an error message for me on the dokku deployment linked in the PR. I can't merge this unless/until I can test it. |
|
redeployed app and seems to be working on my end, I pushed the most updated working version that has edit and delete and create functionality note: still has the edit page bugs that I pointed out in the edit page PR which will be fixed in a different PR |
pconrad
reviewed
Jun 1, 2024
pconrad
requested changes
Jun 1, 2024
pconrad
added
the
FIXME-See CR
SR33G33
removed
the
FIXME-See CR
pconrad
added
the
FIXME-Merge Conflicts
SR33G33
removed
the
FIXME-Merge Conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Edit Page for Admins is visible in the Schools tab when edit button is pressed
allows user to edit successfully
TODO: Still allows users to edit abbrev which cause some funky stuff to happen where it overwrites another table entry if the new abbrev matches an old one
This branch is currently deployed to: https://proj-organic-sr33g33-dev.dokku-12.cs.ucsb.edu/
*Note if the deployed app looks like an old one I might just have pushed a different branch to debug, shoot me a message on slack and I can deploy the correct branch