Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

School Edit Page now prevents user from editing the Abbrev param #45

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

SR33G33
Copy link
Contributor

@SR33G33 SR33G33 commented Jun 2, 2024

Closes #4
Closes #33
abbrev is now greyed out in the edit page so it doesn't get edited

image

deployed on : https://proj-organic-sr33g33-dev.dokku-12.cs.ucsb.edu/

jason-rodrigues
jason-rodrigues previously approved these changes Jun 2, 2024
Copy link
Contributor

@jason-rodrigues jason-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@SR33G33 SR33G33 self-assigned this Jun 2, 2024
@pconrad pconrad added the FIXME-Merge Conflicts Please fix the merge conflicts then remove this label label Jun 5, 2024
@SR33G33 SR33G33 removed the FIXME-Merge Conflicts Please fix the merge conflicts then remove this label label Jun 5, 2024
pconrad
pconrad previously approved these changes Jun 5, 2024
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad force-pushed the Sreeganesh-SchoolsCRUD-BackendBugs branch from 114f42c to dc4c775 Compare June 6, 2024 00:21
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad merged commit 9576d3d into main Jun 6, 2024
9 checks passed
@pconrad pconrad added the 5 5 points label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 5 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

School Page Backend Bugs EPIC: Frontend for Schools CRUD (some of which can be done in parallel)
3 participants