Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 🎉 Add zoom transition on linked image hover #351

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Conversation

Herm71
Copy link
Member

@Herm71 Herm71 commented Aug 14, 2024

What does this do/fix?

Adjust styles to add a zoom transition on all linked images (images wrapped in an <a> tag).

This effect was included in the UCSC Query Card developed by Modern Tribe. This PR incorporates that behavior on every linked image. The redundant code was removed from the UCSC Query Card.

Additionally, this code includes the "prefers-reduced-motion" media query, which allows a user to disable this effect via their OS.

QA

Links to relevant issues

Screenshots/video:
https://github.com/user-attachments/assets/d0168da2-bde0-4362-9bdf-205db3554a56

Tests

Does this have tests?

  • Yes, see video. These are CSS changes. It's tested by building, then using one's OS settings to reduce motion.

@Herm71 Herm71 self-assigned this Aug 15, 2024
@Herm71 Herm71 added the enhancement New feature or request label Aug 15, 2024
@Herm71 Herm71 requested a review from knice August 15, 2024 13:28
@Herm71 Herm71 marked this pull request as ready for review August 15, 2024 15:28
@Herm71 Herm71 marked this pull request as draft August 15, 2024 15:30
@Herm71 Herm71 marked this pull request as ready for review August 15, 2024 15:35
@knice knice merged commit e7aedc9 into main Sep 17, 2024
@knice knice deleted the Herm71/issue340 branch September 17, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants