Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only produce .smt2 files when the save flag is turned on #712

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Only produce .smt2 files when the save flag is turned on #712

merged 1 commit into from
Oct 17, 2024

Conversation

gergoerdi
Copy link
Contributor

facundominguez
facundominguez reviewed Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@facundominguez facundominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking good to me. I shared just one comment about the order in which things are written to the log.

src/Language/Fixpoint/Smt/Interface.hs Outdated Show resolved Hide resolved
facundominguez
facundominguez approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@facundominguez facundominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facundominguez facundominguez merged commit d69618e into ucsd-progsys:develop Oct 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundominguez facundominguez facundominguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gergoerdi @facundominguez