Enhance the core transformation to strictify let pattern matching #2337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes more effective a transformation in the code to rewrite
to
A new case is handled, and the transformation is constrained to apply only in cases where it doesn't break the type of the transformed expression.
Much of the challenge is that when we get to transform core, the lazy patterns have already been desugared to a bunch of lets which use projections instead. See the documentation of
strictifyLazyLets
for details.The
Isort.hs
test had to be disabled as explained in #2335.This PR is related to #2257. It doesn't address that issue, but it makes more predictable how LH will transform core. Fixing #2257 would require documenting the transformation to the user.