Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to simplify positioning of existing and new decals #179

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

passivestar
Copy link
Contributor

Adds 2 things:

  • A button to set the position of existing decal object to 3D cursor
  • A checkbox to set a new decal position to 3D cursor when duplicating a decal
s.mp4

Note: Code duplication for getting texcoord is potentially a concern, but I found that it's used in many different places so it's better to refactor it separately in the future

@ucupumar
Copy link
Owner

Thanks for another PR! I'm merging this immediately 👍
Anyway, what's the concern about getting the texcoord?

@ucupumar ucupumar merged commit 6c09819 into ucupumar:master Sep 28, 2024
@passivestar
Copy link
Contributor Author

Anyway, what's the concern about getting the texcoord?

There's just a lot of code repetition, potentially something to refactor in the future

image

@passivestar passivestar deleted the decal-positioning branch September 28, 2024 13:51
@ucupumar
Copy link
Owner

I see, yeah there should be a more common function to check if the passed entity is a mask or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants