Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak if tasks contain wakers #31

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Fix memory leak if tasks contain wakers #31

merged 1 commit into from
Aug 3, 2024

Conversation

loyd
Copy link
Contributor

@loyd loyd commented Aug 3, 2024

Closes #30

@loyd loyd force-pushed the main branch 3 times, most recently from 03ee73d to 895d55a Compare August 3, 2024 18:09
@udoprog
Copy link
Owner

udoprog commented Aug 3, 2024 •
edited
Loading

Ooops, good find and nice fix! Thank you!

@udoprog udoprog added the bug Something isn't working label Aug 3, 2024
@udoprog udoprog merged commit 8dde357 into udoprog:main Aug 3, 2024
5 checks passed
@loyd
Copy link
Contributor Author

loyd commented Aug 3, 2024

Thanks for the fast review. Can you release a patch version?

@udoprog
Copy link
Owner

udoprog commented Aug 3, 2024

I'm working on reworking some of the doctests, particularly so they use start_paused and to run as much as possible through miri. But it's coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression v9->v10: tasks storing wakers aren't dropped
2 participants
@loyd @udoprog