Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with non SSL custom domain. #358

Closed
alimuzzaman opened this issue Feb 23, 2019 · 5 comments
Closed

Issue with non SSL custom domain. #358

alimuzzaman opened this issue Feb 23, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@alimuzzaman
Copy link
Contributor

->get_gs_host() function wasn't returning the correct URL.

@antonkorotkov
Copy link
Contributor

@alimuzzaman Is it something users reported or you found that?

@alimuzzaman
Copy link
Contributor Author

@antonkorotkov I found it.

@antonkorotkov
Copy link
Contributor

@alimuzzaman Not sure if that is ok but can you check?

When I type some domain name it does not reflect it in the preview and it does not use it on front-end.

image

But it does when I add https:// (http:// is not working as well)

image

@alimuzzaman
Copy link
Contributor Author

@antonkorotkov

Be advised that the bucket name and domain name must match exactly,

This is why it wasn't working for you.

It's true only when using non SSL domain with google CNAME.

But when using CDN/load balancer it's not required.

@antonkorotkov
Copy link
Contributor

Ok, got it. Closing the issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants