-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multisite wrong GCS path #407
Comments
It does not only affect Gravity forms but Multisite in general.
In GCS @antonkorotkov any thought! |
If we fix the issue, how we will handle existing media? If the user regenerates existing media then the image will be copied to new location. And there will be duplicates. |
Sorry, I did not understand why it will be copied to a new location. Can you inspect the flow in detail for me? |
Server URL: http://localhost/multisite/test1/wp-content/uploads/sites/2/2019/12/xyz.jpg Old URL: https://storage.googleapis.com/udx-ci-develop-alim/multisite/2019/12/xyz.jpg New URL: https://storage.googleapis.com/udx-ci-develop-alim/multisite/sites/2/2019/12/xyz.jpg Here
Prior to now, we didn't have Now if we synchronize image after making changes considering
|
@antonkorotkov please provide some insight here. We need to get this right. |
@alimuzzaman I don't think we have many options here. We can:
I personally, prefer the first option because the old media can play the role of backup for some installations. @ewsopp Do you have any thoughts? |
I think we start using the proper/updated path for new uploads and maintain existing paths for previously uploaded media (regeneration). Is that easy enough? |
@alimuzzaman what do you think about this? I'm not sure if that is something we can do.
|
@ewsopp Yes, that's easy enough. With the current code in Multisite branch: @antonkorotkov Maybe removing them can be optional, via sync tab. |
@ewsopp @antonkorotkov This solution could break things without users realizing it. |
I think so, but I'll come back with some additional notes. |
The text was updated successfully, but these errors were encountered: