-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huge incompatibility with Divi #430
Comments
I'm having this issue as well and it happens even with Divi's Static CSS turned off |
are there any workaround for this? |
Until they get it going I would write a cron like this |
its not sufficient. |
Hello everyone. The issue has been reviewed and confirmed. We are working on it. Thanks for your patience. |
@dchenk @harrystymiest @donbowman can you guys help me testing it? Here is the zip of the fixed version https://github.com/wpCloud/wp-stateless/archive/develop-anton.zip Thanks. |
will do |
I installed on my Goddaughter's model portfolio site (Not a "client" site, Have a backup) ill monitor the size over the next 24H or so |
|
No issues for me so far |
Sorry, it does not look like WP-Stateless errors. Can you try maybe re-installing the Divi? |
this was after the re-isntall of divi, let me try again. i had 4.0.8 (which is last version that my site would render w/ w/ wp-stateless). let me try again |
ok the issue was the divi security patcher which was the workaround for a security flaw on 4.0.8. |
I'm ready to say this is resolved |
Closing the issue. Fix will be added to the next release. Thanks. |
This plugin's 'sanitize_file_name' filter totally screws up the file-based caching that Divi and the plugins Bloom and Monarch do. When the Divi theme, for example, serializes the minified CSS for a page or for the site's global styling, or when it serializes the content of a page into a binary ".data" file for caching, it constructs a potential file name for this content using a particular structure for this file name. It then does a
glob
of the potential target directory to see if there already is an existing file that can be used (previously cached). However, when Divi constructs this potential file name, it passes it through thesanitize_file_name
function (see the constructor of theET_Core_PageResource
class inDivi/core/components/PageResource.php
), which applies the 'sanitize_file_name' filter.This means that wp-stateless prepsends this potential file name with a random string, so in the call to
glob
no matching files are found. This means that, on every single request for that page, Divi will write the serialized data to disk after globbing for an existing cached file!This behavior quickly used up all 20 GB of the disk where these files were being written, and it noticeably hurt performance of my websites.
I'm running the version 2.3.2 of this plugin in stateless mode. Please address this as soon as possible.
The text was updated successfully, but these errors were encountered: