Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and clean up the current CLI implementation #450

Closed
antonkorotkov opened this issue Feb 26, 2020 · 7 comments
Closed

Review and clean up the current CLI implementation #450

antonkorotkov opened this issue Feb 26, 2020 · 7 comments
Assignees
@alimuzzaman

Comments

@antonkorotkov
Copy link
Contributor

The current CLI implementation is outdated and it is possible that it may just not work.
Need to review it and test/fix/cleanup or remove and start from scratch if needed.
@antonkorotkov
Copy link
Contributor Author

I think the new command (wp sm) should be renamed to something else less generic because sm could interfere with another third-party command. How about wp stateless at least?

@antonkorotkov antonkorotkov mentioned this issue Feb 26, 2020
Closed
4 tasks
planv added a commit that referenced this issue Feb 28, 2020
@planv
#450 cli wp sm command renamed to stateless
2418e8d
@planv
Copy link
Contributor

planv commented Feb 28, 2020

The current CLI implementation is working.
Command upgrade uses for update postmeta from old structure to new.

Renamed command sm to stateless.

@antonkorotkov
Copy link
Contributor Author

Ok, let it exist then.

@planv planv mentioned this issue Mar 4, 2020
Merged
@ewsopp ewsopp added this to the v2.4.0 milestone Mar 4, 2020
@ewsopp ewsopp mentioned this issue Mar 4, 2020
Closed
@planv planv linked a pull request Mar 5, 2020 that will close this issue
WP CLI sync. #454
Merged
@planv planv removed a link to a pull request Mar 5, 2020
WP CLI sync. #454
Merged
@ewsopp
Copy link
Member

ewsopp commented Mar 20, 2020

@alimuzzaman can you test this please?

@ewsopp ewsopp assigned alimuzzaman and unassigned planv Mar 20, 2020
@alimuzzaman
Copy link
Contributor

OK, testing.

@planv
Copy link
Contributor

planv commented Mar 26, 2020

@alimuzzaman Is it ok for you or you have any suggestions?

@alimuzzaman
Copy link
Contributor

Command sm renamed to stateless.

wp stateless sync images

@alimuzzaman alimuzzaman mentioned this issue Apr 3, 2020
Merged
@ewsopp ewsopp removed this from the v2.4.0 milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimuzzaman alimuzzaman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@antonkorotkov @planv @ewsopp @alimuzzaman