Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new stateless mode and test compatibilites #482

Closed
2 tasks done
ewsopp opened this issue May 1, 2020 · 12 comments
Closed
2 tasks done

add new stateless mode and test compatibilites #482

ewsopp opened this issue May 1, 2020 · 12 comments
Assignees
@alimuzzaman
Labels
type/new
Milestone
v3.0.0

Comments

@ewsopp
Copy link
Member

ewsopp commented May 1, 2020 •
edited by planv
Loading

  • Add the new "Stateless" mode that does not use local storage at all.
  • Determine which compatibilities work and which compatibilities do NOT work with this new mode.
planv added a commit that referenced this issue May 5, 2020
@planv
#482 add new stateless mode
9e4b2ae
planv added a commit that referenced this issue May 6, 2020
@planv
#482 new mode stateless. fixes for media files which was uploaded on …
07d59d5 
…local server
planv added a commit that referenced this issue May 6, 2020
@planv
#482 sync old media ffiles with new sateless mode
4b79591
@ewsopp ewsopp mentioned this issue May 6, 2020
Closed
7 tasks
@ewsopp ewsopp added the type/new label May 6, 2020
planv added a commit that referenced this issue May 7, 2020
@planv
#482 added hooks for new sateless mode, forcing Cache-Busting
2d9b21c
planv added a commit that referenced this issue May 7, 2020
@planv
#482 added GCS metadata for new mode
cc199b9
planv added a commit that referenced this issue May 8, 2020
@planv
#482 added GCS metadata for new mode
7178247
planv added a commit that referenced this issue May 8, 2020
@planv
#482 sync process, removing media from local server
aff7705
@planv
Copy link
Contributor

planv commented May 12, 2020

@ewsopp With new "Stateless" mode I can't add files to Bucket root. It needs to have folder in Bucket.

So new field Folder shouldn't be empty for "Stateless" mode
image

@alimuzzaman
Copy link
Contributor

image

@planv
Copy link
Contributor

planv commented May 12, 2020

Yes, compatibility with Imagify not working on Stateless mode.
Imagify add mediafiles to local server

@planv
Copy link
Contributor

planv commented May 12, 2020 •
edited
Loading

Review compatibility with "Stateless" mode

  • Advanced Custom Fields Image Crop Addon - not working
  • BuddyBoss - not working
  • BuddyPress - not working
  • Divi - working, compatibility only for filename and cache busting
  • Dynamic Image Support - working
  • Easy Digital Downloads - not working
  • Elementor Page Builder - working
  • EWWW Image Optimizer - not working, problem with thumbnails sizes
  • Gravity Forms - working
  • Imagify Image Optimizer - not working
  • LearnDash LMS - working, compatibility only for cache busting
  • LiteSpeed Cache - not working
  • Polylang Pro - working
  • ShortPixel Image Optimizer - not working
  • Simple Local Avatars - not working, uses local path
  • SiteOrigin CSS - working
  • SiteOrigin Widget Bundle - working
  • VidoRev - working
  • WooCommerce Extra Product Options - working
  • WP Retina 2x Pro - now working
  • WP Smush - working
  • WPBakery Page Builder - notworking
  • WPForms - working

@ewsopp
Copy link
Member Author

ewsopp commented May 12, 2020

@ewsopp With new "Stateless" mode I can't add files to Bucket root. It needs to have folder in Bucket.

Should we just default to the standard Wordpress organization scheme?

@planv
Copy link
Contributor

planv commented May 13, 2020

Should we just default to the standard Wordpress organization scheme?

Yes, we can use our predefined values for Single site and for Multisite by default.

planv added a commit that referenced this issue May 15, 2020
@planv
#482 added predefined values to field Folder on Stateless mode
d2d5329
@planv
Copy link
Contributor

planv commented May 15, 2020

@ewsopp I added predefined value for field Folder on Stateless mode.
Also I added notice, maybe need to change text on it?
изображение

@planv
Copy link
Contributor

planv commented May 15, 2020

@ewsopp

Determine which compatibilities work and which compatibilities do NOT work with this new mode.

I have checked compatibilities with new mode. Most of them are working.
List of compatibilities with comments - #482 (comment)

planv added a commit that referenced this issue May 15, 2020
@planv
#482 set Stateless mode by default if folder Uploads is not writable
92e893e
planv added a commit that referenced this issue May 18, 2020
@planv
#482 use our Folder settings if it is set, instead default
7d3daf5
planv added a commit that referenced this issue May 19, 2020
@planv
#482 added wildcards for new Stateless mode for non-media-files
9830748
@planv
Copy link
Contributor

planv commented May 19, 2020

@ewsopp

Should we disable and hide from list compatibilities which not working on Stateless mode?

@ewsopp
Copy link
Member Author

ewsopp commented May 19, 2020

I don't think we should hide it. Lets disable it, similar to how we treat compatibilities that are disabled when the related plugin is not active.

image

We probably should also add the following message:

This compatibility does not support Stateless mode.

Mockup

image

planv added a commit that referenced this issue May 19, 2020
@planv
#482 disabled compatibilities which not working on Stateless mode
9732d15
@planv
Copy link
Contributor

planv commented May 19, 2020

Done.

image

@planv planv assigned alimuzzaman and unassigned planv May 20, 2020
planv added a commit that referenced this issue May 25, 2020
@planv
#482 fix fir srcset on Stateless mode
a8bd99e
planv added a commit that referenced this issue May 25, 2020
@planv
#482 fix for the_content_filter and removing double year/month from path
87490b7
@alimuzzaman
Copy link
Contributor

Working fine.

planv added a commit that referenced this issue May 28, 2020
@planv
#482 prevent google storage init if json key is empty
38054e6
@ewsopp ewsopp added this to the v3.0.0 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimuzzaman alimuzzaman

Labels
type/new
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
3 participants
@planv @ewsopp @alimuzzaman