Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle PDF thumbnails #577

Closed
antonkorotkov opened this issue Oct 13, 2020 · 3 comments
Closed

handle PDF thumbnails #577

antonkorotkov opened this issue Oct 13, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@antonkorotkov
Copy link
Contributor

Looks like thumbnails are being generated for PDFs.

Example:

image

But they are not being deleted after syncing in Ephemeral mode. I think this is something relatively new. And it is not related to the background processing.

@antonkorotkov antonkorotkov added this to the v3.1.1 milestone Oct 13, 2020
@planv planv self-assigned this Oct 13, 2020
@planv
Copy link
Contributor

planv commented Oct 20, 2020

Current issue with removing thumbnails in Ephemeral mode fixed.

Also I noticed that we don't create thumbnails for PDF in Stateless mode, it is due to using WP_Image_Editor_GD (for StreamWrapper that doesn't save file locally) instead 'WP_Image_Editor_Imagick' (need for generating thumbnails for PDF - https://make.wordpress.org/core/2016/11/15/enhanced-pdf-support-4-7/ ).
@ewsopp Should we add notice about that?

@ewsopp
Copy link
Member

ewsopp commented Oct 20, 2020

I think so, but when would we display it? and what would it say?

@planv planv mentioned this issue Oct 20, 2020
@planv
Copy link
Contributor

planv commented Oct 20, 2020

@ewsopp

I guess here

image

Store and serve media files with Google Cloud Storage only. Media files are not stored locally, but local storage is used temporarily for processing and is required for certain compatibilities, generating thumbnails for PDF documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants