Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): correct event handler binding for document updates and awareness #868

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

RubaXa
Copy link
Contributor

@RubaXa RubaXa commented Oct 28, 2024

Fixed an issue where event handlers for document and awareness updates leaks on destroy.

@RubaXa RubaXa changed the title fix(provider): correct event handler binding for document updates an awareness fix(provider): correct event handler binding for document updates and awareness Oct 29, 2024
nperez0111
nperez0111 previously approved these changes Nov 1, 2024
Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, this looks right to me

@nperez0111 nperez0111 merged commit 1c18ee7 into ueberdosis:main Nov 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants