fix for data attributes not rendering after pr #4082

ueberdosis · Mar 15, 2024 · 1ab920f · 1ab920f
1 parent 0be1c5b
commit 1ab920f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/docs/api/nodes/mention.md b/docs/api/nodes/mention.md
@@ -61,7 +61,7 @@ Mention.configure({
   renderHTML({ options, node }) {
     return [
       "a",
-      { href: '/profile/1' },
+      mergeAttributes({ href: '/profile/1' }, options.HTMLAttributes),
       `${options.suggestion.char}${node.attrs.label ?? node.attrs.id}`,
       ];
   }

diff --git a/packages/extension-mention/src/mention.ts b/packages/extension-mention/src/mention.ts
@@ -26,7 +26,7 @@ export const Mention = Node.create<MentionOptions>({
       renderHTML({ options, node }) {
         return [
           'span',
-          this.HTMLAttributes,
+          mergeAttributes(this.HTMLAttributes, options.HTMLAttributes),
           `${options.suggestion.char}${node.attrs.label ?? node.attrs.id}`,
         ]
       },
@@ -131,8 +131,11 @@ export const Mention = Node.create<MentionOptions>({
         }),
       ]
     }
+    const mergedOptions = { ...this.options }
+
+    mergedOptions.HTMLAttributes = mergeAttributes({ 'data-type': this.name }, this.options.HTMLAttributes, HTMLAttributes)
     const html = this.options.renderHTML({
-      options: this.options,
+      options: mergedOptions,
       node,
     })