fix: prevent suggestions from being active when editor is readonly

ueberdosis · Apr 9, 2022 · c680cca · c680cca
1 parent ab4a0e2
commit c680cca
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/suggestion/src/suggestion.ts b/packages/suggestion/src/suggestion.ts
@@ -169,16 +169,18 @@ export function Suggestion({
 
       // Apply changes to the plugin state from a view transaction.
       apply(transaction, prev, oldState, state) {
+        const { isEditable } = editor
         const { composing } = editor.view
         const { selection } = transaction
         const { empty, from } = selection
         const next = { ...prev }
 
         next.composing = composing
 
-        // We can only be suggesting if there is no selection
-        // or a composition is active (see: https://github.com/ueberdosis/tiptap/issues/1449)
-        if (empty || editor.view.composing) {
+        // We can only be suggesting if the view is editable, and:
+        //   * there is no selection, or
+        //   * a composition is active (see: https://github.com/ueberdosis/tiptap/issues/1449)
+        if (isEditable && (empty || editor.view.composing)) {
           // Reset active state if we just left the previous suggestion range
           if (
             (from < prev.range.from || from > prev.range.to)