fix: Check node type above custom update function for node views (#2081)

ueberdosis · Oct 25, 2021 · ddc9ca8 · ddc9ca8
1 parent 45778b8
commit ddc9ca8
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/react/src/ReactNodeViewRenderer.tsx b/packages/react/src/ReactNodeViewRenderer.tsx
@@ -114,6 +114,10 @@ class ReactNodeView extends NodeView<React.FunctionComponent, Editor, ReactNodeV
       this.renderer.updateProps(props)
     }
 
+    if (node.type !== this.node.type) {
+      return false
+    }
+
     if (typeof this.options.update === 'function') {
       const oldNode = this.node
       const oldDecorations = this.decorations
@@ -130,10 +134,6 @@ class ReactNodeView extends NodeView<React.FunctionComponent, Editor, ReactNodeV
       })
     }
 
-    if (node.type !== this.node.type) {
-      return false
-    }
-
     if (node === this.node && this.decorations === decorations) {
       return true
     }